#5609 Add Ui.toast() hint when public key auto includes within the secure email

FlowCrypt / flowcrypt-browser

FlowCrypt Browser extension for Chrome and Firefox

https://flowcrypt.com

Other

372 stars 48 forks source link

#5609 Add Ui.toast() hint when public key auto includes within the secure email #5657

Closed martgil closed 2 months ago

martgil commented 3 months ago

This PR adds a hint using Ui.toast() to inform the user about the auto-included public keys as attachments.

close #5609

Tests (delete all except exactly one):

Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

[x] addresses the issue it closes (if any)
[x] code is readable and understandable
[x] is accompanied with tests, or tests are not needed
[x] is free of vulnerabilities
[x] is documented clearly and usefully, or doesn't need documentation

martgil commented 3 months ago

error happens when two or more toasts that should be displayed get overridden and the first toast doesn't seem to show up. Still looking into that issue.

martgil commented 2 months ago

Hello @sosnovsky - ready for review.

I have re-opened this PR as I think this is a more suitable one. Here I have changed the toast message which was priotized to be checked since there was already a check next to the toast meant for checking failed email due to revoked key:

https://github.com/FlowCrypt/flowcrypt-browser/pull/5657/commits/8645ee14eb1899ffe91a7a3fe0ac5db4eeed75c9

martgil commented 2 months ago

Hi @sosnovsky ready for review again. Thank you!

martgil commented 2 months ago

Short demo

Screencast from 2024-04-13 12-48-30.webm

martgil commented 2 months ago

@sosnovsky All good now. thanks!