Closed martgil closed 1 month ago
Hi @sosnovsky, I hope you're doing well. I'd like to check if you have any preferences regarding the date and time format, or if the one proposed in this PR is sufficient?
Hi @sosnovsky I have re-run the test but the failing one is not related to my PR. This should be good to go.
Hi @sosnovsky does this look good to you? I also plan to share a build coming from this PR to double-check if the user would get his desired date and time when print-previewing email -- it should work fine.
Looks good now, you can send test build to reporter for checking
Thanks, @sosnovsky. I've informed him, but still haven't heard their feedback. I'll update you as soon as I have it.
@martgil I merged this PR, to include it in the upcoming release.
The goal of this PR is to pull the exact time an email was received from Gmail. This also resolves issues with accurately retrieving the time, whether it's in a 12 or 24-hour format, since it's already provided within the pulled data from Gmail.
close #5664
Screenshots: Opening the same email using different time format
12 hour format:
24 hour format:
To change time format in Gmail:
1.) Go to Gmail Settings -> See all settings. 2.) Change language from 'English US' to 'English UK'. 3.) Save and open the desired email.
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):