FlowCrypt / flowcrypt-browser

FlowCrypt Browser extension for Chrome and Firefox
https://flowcrypt.com
Other
375 stars 46 forks source link

Improve the "Add a public key to email address" page texts and UI #5695

Closed vahram-papazyan closed 5 months ago

vahram-papazyan commented 5 months ago

Currently the page looks like this:

add-pubkey

I suggest:

vahram-papazyan commented 5 months ago

@sosnovsky What do you think?

sosnovsky commented 5 months ago

Remove overflow

👍

Use green for texts and "OK" button

Current color highlights that it can be dangerous to manually import public keys, let's continue using it. But OK button can be renamed to Import

Add hover similar to the browser's setting section buttons

We don't use hover for buttons in other places, so let don't add hover here too.

vahram-papazyan commented 5 months ago

Current color highlights that it can be dangerous to manually import public keys, let's continue using it. But OK button can be renamed to Import

Maybe we could use a danger icon in that case?

We don't use hover for buttons in other places, so let don't add hover here too.

My bad, should write "active" effect, not hover, like this:

https://drive.google.com/file/d/1lDyakxpn0NFegBXCGtbCbWELBjLRQgZs/view?usp=sharing

sosnovsky commented 5 months ago

My bad, should write "active" effect, not hover, like this:

Ah, this effect can be added there 👍

Maybe we could use a danger icon in that case?

There are no icons on other buttons in FlowCrypt extension, so it'll look different from them, let's leave only text for consistency.

vahram-papazyan commented 5 months ago

Ah, this effect can be added there 👍

It seems like there was this effect but for some reason it didn't work yesterday when i checked.