search

FlowCrypt / flowcrypt-browser

FlowCrypt Browser extension for Chrome and Firefox
https://flowcrypt.com
Other
375 stars 46 forks source link

Error when trying to send empty signed-only message #5730

Closed sosnovsky closed 4 months ago

sosnovsky commented 4 months ago

I noticed just now that when trying to send a blank signed message, there was this unhandled error message that occurred.

image

Originally posted by @martgil in https://github.com/FlowCrypt/flowcrypt-browser/issues/5599#issuecomment-1940538245

martgil commented 4 months ago

Hi @sosnovsky - this bug no longer exists as of this moment. But before, it exists when sending a signed email without an email body and title and the error above occurs.

Let's close this one.

sosnovsky commented 4 months ago

Hmm, this issue still occurs for me in master branch

martgil commented 4 months ago

I've checked it on my end as well and didn't been able to replicate it (I also updated the original issue stating that i'm unable to replicate it back in Feb - so possibly its from different root cause) . Could you share the steps you took to reproduce it? Perhaps it differs from the way we tested it.

martgil commented 4 months ago

For example, here's how I tested it based on my recollection:

Screencast from 2024-05-23 20-04-28.webm

sosnovsky commented 4 months ago

Try to remove your signature from message input and you'll get mentioned error

martgil commented 4 months ago

Thanks - I can replicate the issue now. Will proceed into fixing this.