FlowCrypt / flowcrypt-browser

FlowCrypt Browser extension for Chrome and Firefox
https://flowcrypt.com
Other
372 stars 48 forks source link

#5730 Fix error when sending blank signed message #5732

Closed martgil closed 1 month ago

martgil commented 1 month ago

This PR improves the case where sending an empty signed message using FlowCrypt returns unhandled error. This is due to createCleartextMessage() not accepting empty message. So passing a newline that would serve as empty message would satify the condition when user choose to send blank signed email when asked by the FlowCrypt browser extension.

close #5730


Tests (delete all except exactly one):


To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

martgil commented 1 month ago

Hi @sosnovsky, I think this particular one does not need to test for such a small changes. Would you agree on that or should I make another test for sending blank signed message?