search

FlowCrypt / flowcrypt-browser

FlowCrypt Browser extension for Chrome and Firefox
https://flowcrypt.com
Other
372 stars 48 forks source link

"see original" functionality isn't working #5733

Closed sosnovsky closed 1 month ago

sosnovsky commented 1 month ago
  1. Open encrypted thread
  2. Click See original button
  3. Popup with original message opens, but FlowCrypt decrypts original message again, so there is no ability to check original message content

@ioanmo226 seems like it was caused by changes in the manifest v3 migration, it worked well in the previous release. Please check this one after finishing your current task, thanks

ioanmo226 commented 1 month ago

Hmmm... I couldn't reproduce issue.(tried on master branch) When I click see original it correctly shows encrypted content. Could you try to reproduce and let me know the reproduce steps?

image

ioanmo226 commented 1 month ago

We also have ui test settings - inbox - show original

martgil commented 1 month ago

Hi @ioanmo226 - sorry for the interuption. I think what Roma's referring to is the "see original" button in Gmail. Where it returns another FlowCrypt-rendered solo email thread instead of just returning the original message.

Steps to reproduce:

  1. Open Gmail with FlowCrypt installed.
  2. Open an email from which FlowCrypt browser extension is able to recognize (encrypted or signed).
  3. Click on "see original".
  4. Observe the newly opened window where the message is still FlowCrypt-rendered.
ioanmo226 commented 1 month ago

image

This one also works fine though

martgil commented 1 month ago

I mean the green "see original" button on the right-side of every FlowCrypt-recognizable emails.

ioanmo226 commented 1 month ago

Aha, I see Yeah, I can reproduce this issue too Thank you

martgil commented 1 month ago

No worries - thanks!

sosnovsky commented 1 month ago

Yeah, I've missed to note that it happens in Gmail UI, not in our encrypted inbox. @martgil thanks for explanation!