#5681 Replace OSSAR with ESLint workflow

FlowCrypt / flowcrypt-browser

FlowCrypt Browser extension for Chrome and Firefox

https://flowcrypt.com

Other

372 stars 48 forks source link

#5681 Replace OSSAR with ESLint workflow #5735

Closed martgil closed 1 month ago

martgil commented 1 month ago

This PR replaces OSSAR GitHub action with ESLint with the goal of running straight-forward ESLint test.

close #5681

Tests (delete all except exactly one):

Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

[ ] addresses the issue it closes (if any)
[ ] code is readable and understandable
[ ] is accompanied with tests, or tests are not needed
[ ] is free of vulnerabilities
[ ] is documented clearly and usefully, or doesn't need documentation

martgil commented 1 month ago

Thanks Roma - I'll check each comments and the apply necessary changes.

github-advanced-security[bot] commented 1 month ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

martgil commented 1 month ago

Hi @sosnovsky this one is ready for review. thank you!

martgil commented 1 month ago

By the way, Roma - do you know of any better and pleasing way to performing debugging in general. I don't like to my PRs populated with this commits info so I'd like to find a way to minize them as much as possible. Thank you for your advice!

martgil commented 1 month ago

@sosnovsky Thank you for your help. I did my best to fix it, but you found a better way. I believe this one is ready to merge.

sosnovsky commented 1 month ago

By the way, Roma - do you know of any better and pleasing way to performing debugging in general. I don't like to my PRs populated with this commits info so I'd like to find a way to minize them as much as possible. Thank you for your advice!

Hi @martgil, do you mean debugging of github actions? You can run the same commands locally, but some steps will still require pushing commits to github for testing how it works in remote environment.

As for me, there is no issue with a large number of commits, as on the merge it'll still be just 1 commit.

martgil commented 1 month ago

but some steps will still require pushing commits to github for testing how it works in remote environment.

Thank you, Roma, for your guidance.