FlowCrypt / flowcrypt-browser

FlowCrypt Browser extension for Chrome and Firefox
https://flowcrypt.com
Other
372 stars 48 forks source link

Pressing "Enter" twice in beginning/endings of quoted text required before a newline actually rendered #5740

Closed martgil closed 3 weeks ago

martgil commented 1 month ago

Description:

It was reported to us that it requires them to press the "Enter" on their keyboard twice before a newline to render. Upon further investigation, the issue exists when interacting onto the beginning or endings of the quoted text. To be specific, its on the the line where the "On , wrote:" starts or at the last occuring line of the quoted text "> some quoted text...".

Steps to reproduce:

  1. Open Gmail with FlowCrypt browser extension set up.
  2. Open any FlowCrypt-renderable emails (encrypted+signed or signed) in your inbox.
  3. Click on "Secure Reply".
  4. Click onto the "..." icon button on the bottom part of the Secure reply box to see the quoted email text.
  5. On the section "On , wrote:" or at the last occuring line of the quoted text "> some quoted text...", try to press Enter and you'll not be getting an expected newline. It will require you to press Enter twice for a newline to be inserted.

Reference: https://mail.google.com/mail/u/human@flowcrypt.com/#inbox/QgrcJHsbjBtCThLpRmNDcjlkLmVBPrQHhVB

sosnovsky commented 1 month ago

Maybe something related to https://github.com/FlowCrypt/flowcrypt-browser/issues/5599 ?

martgil commented 1 month ago

I checked it and its not related to it but its about how we process quoted email in the blockquote - separateQuotedContentAndRenderText()