FlowCrypt / flowcrypt-browser

FlowCrypt Browser extension for Chrome and Firefox
https://flowcrypt.com
Other
372 stars 48 forks source link

#5740 Re-arrange processing of newlines in quoted email #5743

Closed martgil closed 3 weeks ago

martgil commented 1 month ago

This PR re-arrange the processing of newlines in quoted email + remove style which results to "inline divs" that causes issue described in #5740.

close #5740


Tests (delete all except exactly one):


To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

martgil commented 1 month ago

Hi @sosnovsky - I will also share another custom build with the reporting user to confirm the fix, in addition to my personal verification.

martgil commented 3 weeks ago

To test this one manually, in addition to the updated test:

  1. ) Open any secure email on Gmail that the FlowCrypt extension can render.
  2. ) Once a secure email from your inbox, click the "..." icon to see the quoted text part.
  3. ) On the section where the line "On 202x-01-01 at 12:00, user@example.com wrote:" try to press enter and you'll get the desired newline compare with bugged version where div's after div's is injected due to the "inline-block" css property from the consumer build. The issue that happens when interacting onto the last instance of ">" in the quoted text part is also fixed.
martgil commented 3 weeks ago

Hi @sosnovsky - this one is ready for review. thank you!