#5741 Refactor IGNORE_ERR_MSG for pattern matching on welcome-message endpoint

FlowCrypt / flowcrypt-browser

FlowCrypt Browser extension for Chrome and Firefox

https://flowcrypt.com

Other

372 stars 48 forks source link

#5741 Refactor IGNORE_ERR_MSG for pattern matching on welcome-message endpoint #5744

Closed martgil closed 4 weeks ago

martgil commented 1 month ago

This PR refactors the IGNORE_ERR_MSG pattern for the welcome-message endpoint to prevent reporting errors.

close #5741

Tests (delete all except exactly one):

Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

[x] addresses the issue it closes (if any)
[x] code is readable and understandable
[x] is accompanied with tests, or tests are not needed
[x] is free of vulnerabilities
[x] is documented clearly and usefully, or doesn't need documentation

martgil commented 1 month ago

@sosnovsky Ready for review. Thank you!

martgil commented 1 month ago

Hi @sosnovsky

Out of topic - I think we should reconfigure the "Security" tab settings for this repo to remove the OSSAR GitHub action and some others with no configurations found: Code scanning results / ESLint Completed in 2s — 1 configuration not found.

sosnovsky commented 1 month ago

Hi @sosnovsky

Out of topic - I think we should reconfigure the "Security" tab settings for this repo to remove the OSSAR GitHub action and some others with no configurations found: Code scanning results / ESLint Completed in 2s — 1 configuration not found.

Right, thanks for noticing! I removed OSSAR from Security tab

sosnovsky commented 1 month ago

Hi @martgil, can you please work on finishing this PR before working on other tasks, so it can be included in the next browser extension release (in the end of this week, or in the beginning of the next one). Thanks!