search

FlowCrypt / flowcrypt-browser

FlowCrypt Browser extension for Chrome and Firefox
https://flowcrypt.com
Other
373 stars 46 forks source link

#5667 Decrypt messages in Thunderbird #5824

Closed sosnovsky closed 2 months ago

sosnovsky commented 2 months ago

This PR added message decryption and its necessary UI improvements on Thunderbird email client.

close #5667

Tests (delete all except exactly one):

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

gitguardian[bot] commented 2 months ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [2422507](https://dashboard.gitguardian.com/workspace/138782/incidents/2422507?occurrence=163492857) | Triggered | Generic Password | f901bc5cd7d7b9c310351e5f00f5585c0e8d73df | extension/chrome/elements/compose.ts | [View secret](https://github.com/FlowCrypt/flowcrypt-browser/commit/f901bc5cd7d7b9c310351e5f00f5585c0e8d73df#diff-d4cf94a246767c279febedbcfaf71d477ef82f8831c444b7e49f427c64951e19L174) | | [2422507](https://dashboard.gitguardian.com/workspace/138782/incidents/2422507?occurrence=164674930) | Triggered | Generic Password | 1f5601228f89c56c77494b7a04ed6c680e9b4201 | extension/chrome/elements/compose.ts | [View secret](https://github.com/FlowCrypt/flowcrypt-browser/commit/1f5601228f89c56c77494b7a04ed6c680e9b4201#diff-d4cf94a246767c279febedbcfaf71d477ef82f8831c444b7e49f427c64951e19L174) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

sosnovsky commented 2 months ago

Hi @martgil, I created updated PR with scripts injection based on your initial https://github.com/FlowCrypt/flowcrypt-browser/pull/5796, seems to work well. Can you please check it too, thanks!

martgil commented 2 months ago

Hi @sosnovsky - I think we can merge this one now. thank you!

sosnovsky commented 2 months ago

Hello @martgil, I've added some code simplifications, can you please re-check, thanks!