FlowCrypt / flowcrypt-ios

FlowCrypt iOS App
https://flowcrypt.com
Other
32 stars 10 forks source link

Add `No result` image + text in mail folder screen #1684

Closed ioanmo226 closed 2 years ago

ioanmo226 commented 2 years ago

Currently, when there are no emails/threads found, it displays nothing. I think we should display No result image + text for no results. Better if we display different no result images+texts for folder types like Gmail app does. (like for spam folder, we may display Hooray no spam here and no spam image)

tomholub commented 2 years ago

Could you share a screenshot of what it currently looks like?

We could start with simple spam folder is empty

ioanmo226 commented 2 years ago

Our current app image

Gmail App image image

tomholub commented 2 years ago

Thank yo for noticing this - let's do spam folder is empty

ioanmo226 commented 2 years ago

With no images?

tomholub commented 2 years ago

I see you'd prefer the icons :-) Can we get these from default ios icons? make them bigger and 50% opacity? If it's something easy like that, I'm not against.

You'll still need to handle non-standard lables/folders, maybe with a default icon (of a folder / label)

ioanmo226 commented 2 years ago

Yeah. Well, I don't think so, We can get icons like trash, inbox but I couldn't find spam, sent icons in default ios icons

ioanmo226 commented 2 years ago

Correct

You'll still need to handle non-standard lables/folders, maybe with a default icon (of a folder / label)

sosnovsky commented 2 years ago

Well, I don't think so, We can get icons like trash, inbox but I couldn't find spam, sent icons in default ios icons

We can use one of these icons for Sent folder:

Screenshot 2022-06-14 at 16 03 13

And for Spam:

Screenshot 2022-06-14 at 16 04 29
ioanmo226 commented 2 years ago

Sounds good. Thanks

tomholub commented 2 years ago

These standard iOS? If so, looks good to me. Maybe paperplane.fill and exclamationmak.shield.fill. And similarly for other folders that can have relatively matching icons. Then some default with a fill for all other folders.

Use larger size, green color that we use in the app but 50% opacity. Let's see what it looks like.

ioanmo226 commented 2 years ago

Yes. ok

sosnovsky commented 2 years ago

These standard iOS? If so, looks good to me. Maybe paperplane.fill and exclamationmak.shield.fill. And similarly for other folders that can have relatively matching icons. Then some default with a fill for all other folders.

Yes, it's default iOS icons from SF Symbols font.

ioanmo226 commented 2 years ago

FYI I also added icons in side menu items. image

tomholub commented 2 years ago

Looks good, but would need some other icon for a draft.

Also, settings and log out now look out of place. Are they different size? Different icon set?

ioanmo226 commented 2 years ago

Also, settings and log out now look out of place. Are they different size? Different icon set?

They are different color. And logout icon uses custom icon (let me fix it

Looks good, but would need some other icon for a draft.

which one do you prefer for draft? image

tomholub commented 2 years ago

here

image

ioanmo226 commented 2 years ago

ok