search

FlowCrypt / flowcrypt-ios

FlowCrypt iOS App
https://flowcrypt.com
Other
33 stars 10 forks source link

Set `isHeadless` to `true` in appium only in semaphoreci #1719

Closed ioanmo226 closed 2 years ago

ioanmo226 commented 2 years ago

I think it might speed up CI speed(Maybe 1.5x-2x) if we set isHeadless to true only in semaphoreci. (I think we still need to see ui results in local as that's useful for debugging). Let me know your thoughts.

https://appium.io/docs/en/writing-running-appium/caps/#:~:text=true%20or%20false-,isHeadless,-Set%20this%20capability

image

ioanmo226 commented 2 years ago

@tomholub , @sosnovsky

sosnovsky commented 2 years ago

@ioanmo226 we can try to run current test suite with isHeadless: true to check that all tests pass with this flag. And we'll also know if tests speed was increased.

If everything is ok then it'll be a nice improvement for CI test process. The only downside I see for know - we won't be able to see screenshots of failed tests (but in this case we can temporarily remove isHeadless flag for getting screenshots)

ioanmo226 commented 2 years ago

@sosnovsky As I checked from local, I tested 10 tests and those all passed with isHeadless: true flag and speed indeed increased (1.5x i think)

We don't need to worry about this. App generates failed screenshots even though we have isHeadless: true flag

The only downside I see for know - we won't be able to see screenshots of failed tests (but in this case we can temporarily remove isHeadless flag for getting screenshots)

sosnovsky commented 2 years ago

We don't need to worry about this. App generates failed screenshots even though we have isHeadless: true flag

Oh, great! Then we definitely should try it on Semaphore

tomholub commented 2 years ago

For these kind of improvements, if you two agree, you don't need my opinion :-)

sosnovsky commented 2 years ago

isHeadless: true decreases tests duration only locally, no improvements on Semaphore.