search

FlowCrypt / flowcrypt-ios

FlowCrypt iOS App
https://flowcrypt.com
Other
33 stars 10 forks source link

Use official SwiftLint plugin #2278

Closed sosnovsky closed 1 year ago

sosnovsky commented 1 year ago

There is now official Xcode build tool plug-in from SwiftLint - https://github.com/realm/SwiftLint#plug-in-support, let's use it instead of current SwiftLintPlugin

ioanmo226 commented 1 year ago

@sosnovsky Which installation method do you prefer? Since we have removed CocoaPods and the .xcworkspace file, I think we should go with brew instead? We can then update the README to include this information.

image

sosnovsky commented 1 year ago

homebrew sounds good, but maybe it's possible to use SwiftLint just with SPM package without need to additionally install it to OS?

ioanmo226 commented 1 year ago

Already implemented with SPM. To do so we need to use SwiftLintPlugin (Xcode build tool). Downside of this is, we can't access the executable directly and therefore we can't call/use it in CI mode.

sosnovsky commented 1 year ago

Downside of this is, we can't access the executable directly and therefore we can't call/use it in CI mode.

We currently don't run swiftlint in CI, so it should be ok to have it only as editor plugin. If we'll need it on CI in the future - we can just add brew install swiftlint to semaphore.yml