FlowCrypt / flowcrypt-ios

FlowCrypt iOS App
https://flowcrypt.com
Other
33 stars 10 forks source link

#2614 fix: decryption error for message sent via encrypted contact page #2640

Closed ioanmo226 closed 1 week ago

ioanmo226 commented 1 week ago

This PR fixed decryption error for message sent via encrypted contact page

close #2614 // if this PR closes an issue


Tests (delete all except exactly one):


To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

ioanmo226 commented 1 week ago

@martgil I'm attempting to send an encrypted message via the encrypted contact page to e2e.enterprise.test@flowcrypt.com for a UI test, but it's throwing the following error.

Could you check the error log and let me know what's causing this? This issue is currently blocking me from implementing the UI test for this fix.

image

martgil commented 1 week ago

Hi @ioanmo226 could be because of expired key most probably.

To verify this claim of mine, please kindly run this public key to the flowcrypt browser extension's compatibility checker: https://flowcrypt.com/pub/e2e.enterprise.test@flowcrypt.com?show=pubkey

The openpgp compatibility checker is in the advanced settings of FlowCrypt settings > experimental.

Observe if the keys are expired (most probably).

Once confirmed, please extend the keys expiration and submit the updated keys to https://flowcrypt.com/attester/update-public-keys

I have the PR on flowcrypt-web for fixing the missing error message details for expired keys and is already under review by Roma.

Hope this helps.

ioanmo226 commented 1 week ago

Hmmmm... Just checked but I think it's not expired yet? image

martgil commented 1 week ago

The issue looks like something else. The key doesnt look expired either. Unfortunately, I dont have access to my computer right now to check the issue but can check it tomorrow if its okay?

ioanmo226 commented 1 week ago

No problem at all. I can work on other issue.

martgil commented 1 week ago

Got it - thanks!

sosnovsky commented 1 week ago

Hi @ioanmo226, mentioned error happens because our config doesn't allow senders from flowcrypt.com domain:

Screenshot 2024-10-28 at 23 13 44

To send encrypted message you should just change email address to non-flowcrypt domain.

ioanmo226 commented 1 week ago

Aha, I see. Thank for checking it.

ioanmo226 commented 1 week ago

However I think we should display actual error message response.error.message (Senders on flowcrypt.com domain not allowed) instead of "Server says this was a bad request" generic error message

martgil commented 1 week ago

Hi @ioanmo226 - yes, I will include this case to my PR right now: https://github.com/FlowCrypt/flowcrypt-web/pull/1856

martgil commented 1 week ago

I'm done at adding some error handling for the reported issue; Already included in https://github.com/FlowCrypt/flowcrypt-web/pull/1856.