FlowFuse / device-agent

An agent to run FlowFuse managed instances of Node-RED on devices
Apache License 2.0
15 stars 8 forks source link

Device agent hangs if Node-RED doesn't exit on SIGINT #206

Closed hardillb closed 7 months ago

hardillb commented 9 months ago

Current Behavior

When the device agent asks the NR instance to shutdown it does so by sending a SIGINT.

If there is a bad node that blocks shutdown we need to be able to forcefully kill the NR process so we can start a new snapshot

Expected Behavior

After a suitable timeout the NR process should be sent a SIGKILL to the process

Steps To Reproduce

No response

Environment

Steve-Mcl commented 7 months ago

@hardillb Should we close this in light of #227 / #236?

hardillb commented 7 months ago

Yes