FlowFuse / device-agent

An agent to run FlowFuse managed instances of Node-RED on devices
Apache License 2.0
15 stars 8 forks source link

Implement deferred stop like nr-launcher #236

Closed Steve-Mcl closed 8 months ago

Steve-Mcl commented 8 months ago

Description

Implement a deferred stop as per nr-launcher

Related Issue(s)

227

Also, potentially the cause of https://github.com/FlowFuse/nr-project-nodes/issues/62

Checklist

Labels

knolleary commented 8 months ago

@Steve-Mcl what's the connection to the Project Nodes issue?

For the Project Nodes issue, Rob was using the Modified Nodes deploy type to make changes. I don't believe restarting Node-RED had anything to do with it.

knolleary commented 8 months ago

Sorry - just caught up on the comments in the linked issue. I'm not certain. Both instances would be trying to listen on the same port and one will fail to start, so I don't see how that results in two copies of the flows running in parallel.

hardillb commented 8 months ago

This is something that required fixing as it was possible to fail to start due to the old version still being running, but as you say I don't think is the cause of Rob's issue

hardillb commented 8 months ago

I'm going to merge this, but as mentioned I don't think it's the cause of the nr-project-nodes problem

Steve-Mcl commented 8 months ago

@knolleary @hardillb right you are. Thanks for the cycles.