FlowFuse / flowfuse

Connect, collect, transform, visualise, and interact with your Industrial Data in a single platform. Use FlowFuse to manage, scale and secure your Node-RED solutions.
https://flowfuse.com
Other
279 stars 63 forks source link

Implementing Device Groups Management #2997

Closed MarianRaphael closed 10 months ago

MarianRaphael commented 1 year ago

User Story

As a FlowForge user, who manages a large number of devices, I want to have the ability to create "Device Groups", So that I can manage and organize my devices more efficiently by grouping and identifying them through common characteristics.

Follow-up story: https://github.com/FlowFuse/flowfuse/issues/2989

Scope

Design

https://github.com/FlowFuse/flowfuse/issues/3103

License

Teams Tier Enterprise Tier

### Tasks
- [ ] https://github.com/FlowFuse/flowfuse/issues/3103
### Follow-ups
- [ ] https://github.com/FlowFuse/flowfuse/issues/3204
MarianRaphael commented 11 months ago

Follow-up: https://github.com/FlowFuse/flowfuse/issues/2989

MarianRaphael commented 11 months ago

Designs in: https://github.com/FlowFuse/flowfuse/issues/3103

MarianRaphael commented 11 months ago

Because the only use case for Device Groups in this iteration is related to Pipelines, Device Groups should be created during Pipeline creation. Later, when introducing more Device Group options, we should allow additional configuration of Device Groups elsewhere. Jumping between screens during the creation of the Pipeline doesn't feel right.

Steve-Mcl commented 11 months ago

@MarianRaphael et al, FYI,

After resurrecting the device tagging branch and working through it with the finalised direction of Device Groups (as discussed in the 2 previous meetings and the update to this OP) I have proposed a new, simplified DB schema for introducing Device Groups. IMO, device groups were moving a sufficient distance away from the mechanics of tagging (of being able to set a devices properties/env vars etc) into its own entity.

I proposed this to Nick and we are in agreement: "simplifying Device Groups to a standalone, one-to many table joined to the device" (see attached schema)

I feel I can deliver this a lot quicker and believe this will not interfere with the (later) concept of tagging for settings / env vars / logical grouping etc.

image

Steve-Mcl commented 11 months ago

@MarianRaphael

Audit log entries for Device Groups was not in the scope or design notes of this work but I assume we/customers will want this?

If yes, can we add / schedule this work?

Thanks.

MarianRaphael commented 11 months ago

Right, this does not fall within the scope of this issue. This would be the first step in that direction: FlowFuse/flowfuse#3268. I will open a follow-up issue specifically for Device Group Audit log entries.

MarianRaphael commented 11 months ago

Edit: @Steve-Mcl Please change the Tier to Enterprise

Steve-Mcl commented 11 months ago

Edit: @Steve-Mcl Please change the Tier to Enterprise

Done - fdefa11

Steve-Mcl commented 10 months ago

Edit: @Steve-Mcl Please change the Tier to Enterprise

Front end updated

image

knolleary commented 10 months ago

@MarianRaphael can I clarify the licensing requirement here.

change the Tier to Enterprise

Do you mean this should only be available to Enterprise licensed platforms, or Enterprise tier teams?

The current implementation is the former - so the feature will be available to all team types on FF Cloud. If this is only meant to be available to Enterprise tier teams on FF Cloud we'll need to implement that.

MarianRaphael commented 10 months ago

@knolleary @Steve-Mcl What I mean is the "Enterprise tier" for FF-Cloud as well as for self-hosted FF instances.

Steve-Mcl commented 10 months ago

Staging verification: 20/12/2023

"Steve on Staging" team

Device Group Ops