FlowFuse / flowfuse

Connect, collect, transform, visualise, and interact with your Industrial Data in a single platform. Use FlowFuse to manage, scale and secure your Node-RED solutions.
https://flowfuse.com
Other
283 stars 64 forks source link

Add targetSnapshot info to Device Group page #3672

Closed Steve-Mcl closed 7 months ago

Steve-Mcl commented 7 months ago

Task generated from the checklist in Improve Snapshot lifecycle handling #3622

Steve-Mcl commented 7 months ago

@knolleary

Q1: Is it the expectation that this be a column in the Device Groups list page or in the individual Device Group (or both)?

Mock up applied to device groups list page image

Mock up applied to device group page image

Q2: would this iteration expect the ability to remove the snapshot from the group (as part of the overall Snapshot lifecycle improvements) or perhaps add that as a task to #3622?

Steve-Mcl commented 7 months ago

@joepavitt I should probably have tagged yourself in case you have some UI/UX preferences here?

e.g. perhaps an overview page (like devices and instances have) is a better 1st iteration?

joepavitt commented 7 months ago

Not sure we need a full page - how about something in the top-right, where "Open Editor", etc. would normally live for instances. Lots of white space there now for device groups - and detailing the target snapshot seems sensible?

Steve-Mcl commented 7 months ago

@joepavitt only target snapshot? Only in the "Device Group" or "Device Groups" page (or both)?

Regarding whitespace: there is a LOT in the tables too.

Device Groups Image

Device Group Image

For reference, devices show the "Active Snapshot" in the Instance->Devices table.

joepavitt commented 7 months ago

Device Groups:

Device Group:

knolleary commented 7 months ago

Q2: would this iteration expect the ability to remove the snapshot from the group (as part of the overall Snapshot lifecycle improvements) or perhaps add that as a task to https://github.com/FlowFuse/flowfuse/issues/3622?

Add 'ability to remove snapshot from group' as a separate task. The goal here is just to communicate the snapshot information which is otherwise unknown.

Steve-Mcl commented 7 months ago

Q2: would this iteration expect the ability to remove the snapshot from the group (as part of the overall Snapshot lifecycle improvements) or perhaps add that as a task to #3622?

Add 'ability to remove snapshot from group' as a separate task. The goal here is just to communicate the snapshot information which is otherwise unknown.

done - added task to #3622

Steve-Mcl commented 7 months ago

Current task:

Current state/progress:

Device Groups

Image

Device Group with target set

Image

Device Group without target set

Image

Steve-Mcl commented 7 months ago

verified on staging