FlowFuse / flowfuse

Build bespoke, flexible, and resilient manufacturing low-code applications with FlowFuse and Node-RED
https://flowfuse.com
Other
243 stars 59 forks source link

Ensure settings change toast informs user a restart is required. #4053

Closed Steve-Mcl closed 1 week ago

Steve-Mcl commented 1 week ago

closes #2581

Description

Related Issue(s)

Closes #2581

Checklist

Labels

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.71%. Comparing base (60e704a) to head (49aed17).

:exclamation: Current head 49aed17 differs from pull request most recent head 878000e

Please upload reports for the commit 878000e to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4053 +/- ## ======================================= Coverage 78.71% 78.71% ======================================= Files 284 284 Lines 13008 13008 Branches 2897 2897 ======================================= Hits 10239 10239 Misses 2769 2769 ``` | [Flag](https://app.codecov.io/gh/FlowFuse/flowfuse/pull/4053/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FlowFuse) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/FlowFuse/flowfuse/pull/4053/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FlowFuse) | `78.71% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FlowFuse#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Steve-Mcl commented 1 week ago

Updated wording in reword to remove doubt about this being auto or manual restart

NOTE: this now also touches the Env Vars file which was used as a basis for the original modifications. In short, it keeps them in line with one another.

joepavitt commented 1 week ago

Just waiting for final tests to pass before merging