Closed cstns closed 2 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.72%. Comparing base (
c03fe4f
) to head (3e542b2
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I won't be able to review this today, so if someone else can step in, would appreciate it. My main point of concern is that if a user is logged in and viewing Team 1, and they directly navigate in the browser to a Team 2 page (e.g. viewing instances) that the new view reflects the correct team's data
I added two new tests to cover these specific scenarios
@Steve-Mcl thanks Steve, just left my own comments on this too
Remove trickle down router props and cohesive way of using team, teamMembership and isVisitingAdmin
Description
Focusing mainly on teamMembership & team props which can be used directly from the permissionsMixin, or using accessing the account store directly where the permission mixin is not used.
The isVisitingAdmin computed prop has also been moved in the permissionsMixin
Related Issue(s)
none
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label