Failure to create assets folder results in unfriendly server 500 toast

FlowFuse / flowfuse

Connect, collect, transform, visualise, and interact with your Industrial Data in a single platform. Use FlowFuse to manage, scale and secure your Node-RED solutions.

https://flowfuse.com

Other

278 stars 63 forks source link

Failure to create assets folder results in unfriendly server 500 toast #4467

Closed Steve-Mcl closed 1 month ago

Steve-Mcl commented 2 months ago

Errors raised by attempting to generate a folder with an invalid name report back to the user via a toast however it is an unfriendly 500 error

chrome_pNFRYsZGVt

Can we check the error type and report a more friendly message like "Invalid folder name"?

Originally posted by @Steve-Mcl in https://github.com/FlowFuse/flowfuse/issues/4422#issuecomment-2337492327

joepavitt commented 1 month ago

A 500 error here suggests server falls over too?

cstns commented 1 month ago

this might be addressed in https://github.com/orgs/FlowFuse/projects/1/views/33?filterQuery=+-is%3Apr++frontend+-status%3Adone frontend/src/components/file-browser/FileBrowser.vue:259 with a bit more info on the response message.

I'm having difficulties reproducing the error on linux though because I can throw any string at it an it will create the folder.

Any methods of forcing the api to fail would be appreciated.