FlowFuse / flowfuse

Connect, collect, transform, visualise, and interact with your Industrial Data in a single platform. Use FlowFuse to manage, scale and secure your Node-RED solutions.
https://flowfuse.com
Other
286 stars 64 forks source link

Deny ACL check for deleted MQTT Clients #4766

Closed hardillb closed 1 week ago

hardillb commented 1 week ago

Fixes Sentry error

Description

Deleted clients trying to publish/subscribe to new topics.

Related Issue(s)

https://flowfuse.sentry.io/issues/6061657489/?referrer=slack&notification_uuid=ca9e75cc-86c3-46d0-bae7-e82be18e94dd&alert_rule_id=14700011&alert_type=issue

Checklist

Labels

knolleary commented 1 week ago

A failing test to investigate.

hardillb commented 1 week ago

Fix had code from USN feature branch, removed

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.79%. Comparing base (b42992f) to head (a7982b6). Report is 46 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4766 +/- ## ======================================= Coverage 78.79% 78.79% ======================================= Files 311 311 Lines 14781 14782 +1 Branches 3384 3385 +1 ======================================= + Hits 11646 11647 +1 Misses 3135 3135 ``` | [Flag](https://app.codecov.io/gh/FlowFuse/flowfuse/pull/4766/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FlowFuse) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/FlowFuse/flowfuse/pull/4766/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FlowFuse) | `78.79% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FlowFuse#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.