FlowFuse / flowfuse

Connect, collect, transform, visualise, and interact with your Industrial Data in a single platform. Use FlowFuse to manage, scale and secure your Node-RED solutions.
https://flowfuse.com
Other
285 stars 64 forks source link

Improved Admin Team view #4770

Open knolleary opened 1 week ago

knolleary commented 1 week ago

Description

This adds filtering options to the Admin Team view to make it easier to filter and search the list.

  1. Adds Sort and Filter options alongside the table
  2. Adds Device count to the table (already had Members and Instance counts. Also added same to the User's Team table for consistency)

The table is now sorted by most recently created ('newest') by default, but can be switched to 'oldest'.

The filters cover:

I time boxed this all to a couple hours - otherwise would have made some further improvements to the presentation of the table.

Need to add some tests for the new filter/sort options on the backend api

image
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 52.77778% with 17 lines in your changes missing coverage. Please review.

Project coverage is 78.72%. Comparing base (58a1c56) to head (243a2d4). Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
forge/db/views/Team.js 10.00% 9 Missing :warning:
forge/db/models/Team.js 60.00% 4 Missing :warning:
forge/routes/api/team.js 73.33% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4770 +/- ## ========================================== - Coverage 78.79% 78.72% -0.07% ========================================== Files 311 311 Lines 14782 14822 +40 Branches 3385 3397 +12 ========================================== + Hits 11647 11669 +22 - Misses 3135 3153 +18 ``` | [Flag](https://app.codecov.io/gh/FlowFuse/flowfuse/pull/4770/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FlowFuse) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/FlowFuse/flowfuse/pull/4770/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FlowFuse) | `78.72% <52.77%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FlowFuse#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knolleary commented 1 week ago

@cstns no rush on this - nice to have, but please don't interrupt your current work