FlowFuse / flowfuse

Connect, collect, transform, visualise, and interact with your Industrial Data in a single platform. Use FlowFuse to manage, scale and secure your Node-RED solutions.
https://flowfuse.com
Other
286 stars 64 forks source link

Fix multiple non-authenticated page layouts #4777

Closed cstns closed 1 week ago

cstns commented 1 week ago

Description

Addresses some ui issues caused by the removal of referencing the viewport height.

Related Issue(s)

Checklist

Labels

knolleary commented 1 week ago

Why are we adding the same CSS multiple times rather than just fixing the common layout once?

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.79%. Comparing base (0b4c35f) to head (326cb4f). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4777 +/- ## ======================================= Coverage 78.79% 78.79% ======================================= Files 311 311 Lines 14782 14782 Branches 3385 3385 ======================================= Hits 11647 11647 Misses 3135 3135 ``` | [Flag](https://app.codecov.io/gh/FlowFuse/flowfuse/pull/4777/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FlowFuse) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/FlowFuse/flowfuse/pull/4777/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FlowFuse) | `78.79% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FlowFuse#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cstns commented 1 week ago

The ff-layout-box component is used in many places, ex modals. I added a utility class to avoid repetition