Closed hardillb closed 6 days ago
Attention: Patch coverage is 5.71429%
with 33 lines
in your changes missing coverage. Please review.
Project coverage is 78.61%. Comparing base (
9c1babb
) to head (d8df913
). Report is 17 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
forge/ee/routes/sso/index.js | 5.71% | 33 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Not sure how to test this without mocking a LDAP server.
The old ldap
nodejs module that we deliberately didn't use has LDAP server support, so we could add it as a dev dependency to test this (and other bits of LDAP SSO)
Agreed we aren't well setup for testing ldap in CI; lets not spend time on that right now.
fixes #4782
Description
Adds ability to test SSO LDAP credentials
This adds 1 new API endpoint and a minor change to the LDAP SSO config page to add test button.
/ee/sso/providers/test
takes the same payload as the update provider, and needs same permissionsReturns 200 and empty json for success or 400 and standard error json for failure, with messages to suite the type of failure.
feedback is via Alerts, success
or for failure
Note, button is secondary, only showing blue here because mouse is over it in the screenshot
Related Issue(s)
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label