FlowFuse / forge-ui-components

Set of FlowForge-themed VueJS components that can be used in any FlowForge web applications.
Apache License 2.0
3 stars 1 forks source link

Fix or add an option to ff-dialog for dialogs containing a dropdown #105

Closed Pezmc closed 1 year ago

Pezmc commented 1 year ago

Story

No response

Description

Since https://github.com/flowforge/flowforge/pull/1201 introduced ff-dropdowns as part of FormRows (instead of native selects), all ff-dialogs containing selects now cause the ff-dialog to scroll, rather than the form options pop-out.

FlowForge has been fixing this by manually overriding the overflow setting for dialogues containing just a dropdown, but a more universal fix; or a flag property to enable "no-scroll" should be added to ff-dialog.

Ideally, the dropdown options should be using absolute positioning so they're not considered part of the document flow, but for a reason I haven't fully wrapped my head around yet, this isn't working.

Example:

Pezmc commented 1 year ago

Also seen in the create stacks dialog, which usually scrolls.

Screenshot 2022-11-23 at 13 45 14

And add device to project:

Screenshot 2022-11-23 at 16 04 04