FlowFuse / helm

A Helm chart to deploy FlowFuse on Kubernetes
Apache License 2.0
5 stars 14 forks source link

PrivateCA configMapName default name not working #450

Closed corentin-pasquier closed 1 month ago

corentin-pasquier commented 1 month ago

Current Behavior

When deploying FlowFuse with a Helm Chart without forge.privateCA. The deployment fails. image

I think the error is here : https://github.com/FlowFuse/helm/blob/main/helm/flowforge/templates/deployment.yaml#L179

Expected Behavior

The deployment should work and the default value for the configMap should be ff-ca-certs as mentioned in the README.

Steps To Reproduce

Create a value.yml file like this and apply it:

          privateCA:
#            configMapName: ff-ca-certs # Do not set this property
            certs: base64privateCA

Environment

Linked Customers

hardillb commented 1 month ago

Thank you for raising this, I think that line should read

          name: {{ .Values.forge.privateCA.configMapName | default "ff-ca-certts" }}

I'll try and get a fix in today