Removing ui-control node instance crash

[78wesley]

Current Behavior

When I remove the ui-control node and click on deploy the instance crash.

The error log that I got is this:

7/10/2024 4:37:17 PM  []        10 Jul 14:37:17 - [red] Uncaught Exception:
7/10/2024 4:37:17 PM  [error]   TypeError: Cannot read properties of null (reading 'send')
    at disconnect (/data/node_modules/@flowfuse/node-red-dashboard/nodes/widgets/ui_control.js:172:31)
    at Socket.emit (node:events:531:35)
    at Socket.emit (node:domain:488:12)
    at Socket.emitReserved (/data/node_modules/socket.io/dist/typed-events.js:56:22)
    at Socket._onclose (/data/node_modules/socket.io/dist/socket.js:561:14)
    at Client.onclose (/data/node_modules/socket.io/dist/client.js:247:20)
    at Socket.emit (node:events:531:35)
    at Socket.emit (node:domain:488:12)
    at Socket.onClose (/data/node_modules/engine.io/build/socket.js:304:18)
    at Object.onceWrapper (node:events:633:28)

Expected Behavior

When I click on deploy it shouldn't crash.

Steps To Reproduce

1. Place a ui-control node and select your path.
2. Click on Deploy
3. Remove the ui-control node
4. Click on Deploy
5. Crashed

Environment

• Dashboard version: 1.12.4
• Node-RED version: 4.0.2
• Node.js version: 20.15.0
• npm version:
• Platform/OS: Flow Fuse Small Instance
• Browser: Brave Version 1.67.123 Chromium: 126.0.6478.126 (Official Build) (64-bit)

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

[joepavitt]

Are you doing a "Full Deploy" or "Partial Deploy" here? I suspect we may have an issue with the latter, but the former would surprise me

[78wesley]

Are you doing a "Full Deploy" or "Partial Deploy" here? I suspect we may have an issue with the latter, but the former would surprise me

I deployed it with Modified Flows.

[joepavitt]

Thanks for confirming - the quick "fix" is to do a Full Deploy - but there is an underlying bug you've found with partial deploys, so thanks for reporting!