search

FlowFuse / node-red-dashboard

https://dashboard.flowfuse.com
Apache License 2.0
205 stars 49 forks source link

Inclusion of a zero sized template node in a group alters its size. #1098

Open mcdonaldajr opened 4 months ago

mcdonaldajr commented 4 months ago

Current Behavior

Initially found this bug when constructing a sub flow with a gauge and a template node. White space appeared above the gauge when displayed on the dashboard. Removing the template node removed the whitespace. The template node size was set to width 0 and height 0. The same behaviour was observed when the gauge and template nodes were removed from the subflow and placed in a flow (although in this case the white space was below the gauge). The template node size is set to auto as zero size is not an available option. This behaviour is observed even when the template node is empty, with no code in it. Image 15-07-2024 at 14 16

Expected Behavior

Inclusion of a zero sized template node in a group should not alter its size.

Steps To Reproduce

flows-2.json

Environment

Have you provided an initial effort estimate for this issue?

I am not a FlowFuse team member

joepavitt commented 3 months ago

So, auto will automatically fill the width of the group, and it's height will just fit to it's content, but with a minimum height of 1 "row".

What's the use case here out of interest? Do you want the ui-template hidden under some circumstances?

mcdonaldajr commented 3 months ago

In the subflow, the height is set to zero, yet still appears as 1 row high. I am using the template node to alter the CSS of another node in the same group. So the template node does not produce any "output" itself. In my case it is altering some of the properties of the node-red-dashboard-2-ui-gauge-classic (colouring the hub and the displayed temperature). If "Hidden" is the way to go, then that is fine.

colinl commented 3 months ago

Have you set the template to type CSS?

mcdonaldajr commented 3 months ago

That fixed it! I hadn't tried that as I had assumed by the name of the option "CSS (Single Page)" that the CSS commands would affect all the groups on the page, but it works! Also I have javascript to set the CSS and I had wrongly assumed that option was for CSS only.