Changing a theme color changes all the themes color

mereshow commented 3 weeks ago

Current Behavior

If you create a new theme, with a new name, and change a color of one of the themes, it changes the corresponding color on all the themes.

Expected Behavior

Each theme should be independent and changing a theme color should only be applied to that theme.

Steps To Reproduce

Go to: Dashboard 2.0 > Theming, clic on "+ Theme". Change a color on one of the themes and save it.

Environment

Dashboard version: 1.11.1
Node-RED version: 3.1.10
Node.js version: v16.20.2
npm version: 8.19.4
Platform/OS: NodeRed on Docker (Linux 5.15.0-112-generic x64 LE)
Browser: Chrome

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

joepavitt commented 3 weeks ago

Can you grab a screen recording of this please, I'm not able to reproduce locally, it works okay for me, note that none of the other themes are modified:

https://github.com/FlowFuse/node-red-dashboard/assets/99246719/e1a4613b-561a-4276-b65c-e0a3d66641e1

mereshow commented 3 weeks ago

In my case it happens only if the themes are not associated to any page (and it only affects those themes).

Screencast from 13-06-24 20:31:03.webm

joepavitt commented 3 weeks ago

Ooh funky - good find. Thanks, will make sure that's addressed.

FlowFuse / node-red-dashboard