FlowFuse / nr-assistant

Apache License 2.0

2 stars 1 forks source link

Add JSON editor code lens #14

Closed Steve-Mcl closed 1 month ago

Steve-Mcl commented 2 months ago

closes #13

Description

NOTE: Release not to be tagged until after https://github.com/FlowFuse/flowfuse/issues/4126 is merged

Adds the code lens to JSON editors

Related Issue(s)

13

Checklist

[x] I have read the contribution guidelines
[ ] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated
- [ ] Upgrade instructions
- [ ] Configuration details
- [ ] Concepts
[ ] Changes flowforge.yml?
- [ ] Issue/PR raised on FlowFuse/helm to update ConfigMap Template
- [ ] Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

[ ] Includes a DB migration? -> add the area:migration label

joepavitt commented 1 month ago

What would the "assistant scope" be here? It's not clear to me where this is set?

Steve-Mcl commented 1 month ago

What would the "assistant scope" be here? It's not clear to me where this is set?

The scope is "All JSON Editors" including but not limited to

template node
inject node
change node
any node that fires up the monaco editor in JSON mode including contrib nodes via TypedInput.

Here is 2 quick demos

chrome_Hns4J0NG7P

The benefit is a seamless integration with all the nodes they use (core and contrib) in their FF Cloud instance.

Steve-Mcl commented 1 month ago

What would the "assistant scope" be here? It's not clear to me where this is set?

Just in case I am misinterpreting and you are asking what the string value of scope will be, then it is json as in in any JSON anywhere, though I DO include the node type in the context object (so we can decern which nodes this is being called from).

joepavitt commented 1 month ago

Sorry, I should have been more specific, in the flow, we add the "assistant scope" from part of the body of the request. What is the differentiating key here to ensure we know it's come from the JSON editor?

Steve-Mcl commented 1 month ago

Sorry, I should have been more specific, in the flow, we add the "assistant scope" from part of the body of the request. What is the differentiating key here to ensure we know it's come from the JSON editor?

I guessed after posting - see previous reply. Does that help?