FlowFuse / nr-launcher

A Laucher for Node-RED that allows settings to be loaded at startup.
Apache License 2.0
6 stars 8 forks source link

Ensure TimeZone is passed to NR #151

Closed hardillb closed 1 year ago

hardillb commented 1 year ago

Fix for https://community.flowforge.com/t/some-repeat-interval-options-for-inject-node-not-working-in-flowforge/188/6

Description

TimeZone not getting set for NR instance

Related Issue(s)

https://community.flowforge.com/t/some-repeat-interval-options-for-inject-node-not-working-in-flowforge/188/6

Checklist

Labels

hardillb commented 1 year ago

@Steve-Mcl I can't see a way to test it, as the only place we could see if it's set would be in a child process of the nr-launcher and we don't actually spin up NR instances in any of the tests (we use the stub driver iirc)

hardillb commented 1 year ago

As for device agent, I don't think so, but we probably need to ensure it's pulled through from the local environment (as time on device is more likely to be useful than project time on cloud)

Steve-Mcl commented 1 year ago

ah my bad, it was late when I viewed the code and for a second thought it was going the the NR settings file.

NP.