Move nr-persistent-context into nr-launcher

FlowFuse / nr-launcher

A Laucher for Node-RED that allows settings to be loaded at startup.

Apache License 2.0

5 stars 7 forks source link

Move nr-persistent-context into nr-launcher #179

Closed knolleary closed 1 year ago

knolleary commented 1 year ago

Description

This pulls @flowforge/nr-persistent-context into this module as a local plugin - rather than continuing to maintain it as a separate dependency.

knolleary commented 1 year ago

Found some workflow references to the old package - removing them

knolleary commented 1 year ago

@ppawlowski I've noticed the 'Build and push packages' action is skipping the tests on this PR - can't see why that is happening.

The existing .github/workflows/build.yml had an if false which I've removed to get the tests running locally - but I realise that isn't using the shared workflow.

Can you look at why the tests are being skipped?

knolleary commented 1 year ago

@hardillb given the previous comment - this pr was still live and shouldn't have been merged