User defined health check interval - Githubissues

FlowFuse / nr-launcher

A Laucher for Node-RED that allows settings to be loaded at startup.

Apache License 2.0

4 stars 6 forks source link

User defined health check interval #228

Closed Steve-Mcl closed 3 months ago

Steve-Mcl commented 4 months ago

Description

allow health poll interval to be set via user setting

NOTES:

Can be approved any time, but should only be merged once all related PRs are approved:

Adds tests:

  Launcher
    ✔ should create a new launcher
    health check
      ✔ has a default value
      ✔ can be set by user
      ✔ cannot be less than 1 second

Related Issue(s)

https://github.com/FlowFuse/nr-launcher/issues/227

TODO

[x] tests

Checklist

[x] I have read the contribution guidelines
[x] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated
- [ ] Upgrade instructions
- [ ] Configuration details
- [ ] Concepts
[ ] Changes flowforge.yml?
- [ ] Issue/PR raised on FlowFuse/helm to update ConfigMap Template
- [ ] Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

[ ] Backport needed? -> add the backport label
[ ] Includes a DB migration? -> add the area:migration label

knolleary commented 3 months ago

We can merge this PR - but the individual driver PRs can be rejected as we don't need to spread the logic out to them all - see https://github.com/FlowFuse/flowfuse/issues/3578#issuecomment-2088639066