FlowFuse / nr-launcher

A Laucher for Node-RED that allows settings to be loaded at startup.
Apache License 2.0
4 stars 6 forks source link

Add CSP headers #230

Closed cstns closed 2 months ago

cstns commented 4 months ago

Description

Take CSP into consideration and allows the editor to be embedded

Related Issue(s)

related to: #3801 part of: #3800

Checklist

Labels

cstns commented 3 months ago

We may even be able to allow them to self configure and overwrite the config if needed.

The less config needed to be done by the end user, the better!

joepavitt commented 3 months ago

@cstns now that you're back from holiday - what's the status on this?

cstns commented 3 months ago

Not looking good. Spoke with @hardillb about it and it seems it's the oauth lib that we're using is causing the issues. I also stumbled across https://github.com/jaredhanson/passport/issues/938 in which the author seems to take his hands of the wheel

knolleary commented 2 months ago

Argh - merged too quick - broken settings file.

cstns commented 2 months ago

can we stop the deployment?

knolleary commented 2 months ago

@cstns it won't get as far as production as we don't automatically update stacks - so no panic there.

Fixed via #241