Wrap unguarded HTTP requests in try/catch - Githubissues

FlowFuse / nr-launcher

A Laucher for Node-RED that allows settings to be loaded at startup.

Apache License 2.0

6 stars 8 forks source link

Wrap unguarded HTTP requests in try/catch #267

Closed hardillb closed 3 months ago

hardillb commented 3 months ago

fixes https://github.com/FlowFuse/flowfuse/issues/4230

Description

Failure of HTTP requests to Persistent Context backend could result in NR crash.

_writeCache now logs failure

getNext logs and returns null, which may mean partial cache received

Related Issue(s)

https://github.com/FlowFuse/flowfuse/issues/4230

Checklist

[x] I have read the contribution guidelines
[ ] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated
- [ ] Upgrade instructions
- [ ] Configuration details
- [ ] Concepts
[ ] Changes flowforge.yml?
- [ ] Issue/PR raised on FlowFuse/helm to update ConfigMap Template
- [ ] Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

[ ] Includes a DB migration? -> add the area:migration label

hardillb commented 3 months ago

Tested with a fileserver that takes 3.5 seconds to respond to a cache load.