FlowFuse / nr-project-nodes

A set of Node-RED nodes for inter-project communication within the FlowFuse platform
Apache License 2.0
5 stars 0 forks source link

IPv6 addresses cannot connect #18

Closed Steve-Mcl closed 1 year ago

Steve-Mcl commented 1 year ago

Current Behavior

If user has specified !Pv6 address, WS (via MQTT.js) throws an error

Full details in MQTT.JS issue raised here: https://github.com/mqttjs/MQTT.js/issues/1569

Expected Behavior

IPv6 addresses should connect

Steps To Reproduce

example yml section for project nodes MQTT Broker Configuration:

#################################################
# MQTT Broker Configuration                     #
#################################################

broker:
  ## Internal url used by the platform to connect to the broker
  url: mqtt://[::1]:9883
  ## External url used by devices to connect to the broker, if different
  public_url: ws://[::1]:9884

Environment

Steve-Mcl commented 1 year ago

Tested localfs, windows and linux - OK.

@hardillb is it possible to adjust an IPv4 to IPv6 on staging (or your own k8s) to test this pls?

hardillb commented 1 year ago

Enabling IPv6 on AWS would not be useful in this case, because access is always going to be via a Hostname not a bare IP address. It has to be because the hostname needs to match the TLS certificate.

Steve-Mcl commented 1 year ago

ok, so local test only is all we can achieve at this point.

hardillb commented 1 year ago

And localfs is the only place bare IP addresses should ever be used