FlowFuse / website

The FlowFuse Website
https://flowfuse.com
MIT License
22 stars 12 forks source link

Some internal links not working on local copy of the website #755

Open robmarcer opened 1 year ago

robmarcer commented 1 year ago

Current Behavior

The links to the demo etc on this page don't work for me http://localhost:8080/handbook/sales

The links work for @joepavitt on his local version.

Video of the problem - https://d.pr/v/sTRada

Expected Behavior

The links should take me to the same path on local as production.

Steps To Reproduce

Install the website local build, run the server, go to the URL, click demo.

Environment

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

ZJvandeWeg commented 1 year ago

Netlify and eleventy locally are different. Also the route of clicking links you took was different I think.

If you click sales in the index.md in the root of the handbook the link to the sales page doesn't have a trailing /, Netlify redirects to have a trailing slash. But Rob locally ran into the case where he could go to localhost:8080/sales with a link to ./demo.md. Correctly the website went to localhost:8080/demo.

So: Internal links to index.html need trailing slashes, all other links need the .md extension.

robmarcer commented 1 year ago

I'm going to do a PR to fix the specific links I've noticed need the trailing slash. I suspect there will be a few other instances that will need resolving at a later date.