FlowWest / CDECRetrieve

An R package to retrieve CDEC data
https://flowwest.github.io/CDECRetrieve/
Other
7 stars 5 forks source link

installation error on R 4.0 #50

Closed hinkelman closed 4 years ago

hinkelman commented 4 years ago

I'm assuming the error is with R 4.0 because I haven't encountered it previously. I get this installation error on macOS High Sierra, macOS Catalina, and Ubuntu 20.04.

> devtools::install_github("flowwest/CDECRetrieve")
Downloading GitHub repo flowwest/CDECRetrieve@master
✓  checking for file ‘/private/var/folders/fj/spwz4xrj5x35c5jfh2vrxn240000gp/T/RtmpOqH16D/remotes22e1ccb39f8/FlowWest-CDECRetrieve-105e61d/DESCRIPTION’ ...
─  preparing ‘CDECRetrieve’:
✓  checking DESCRIPTION meta-information ...
   Warning in grepl(e, files, perl = TRUE, ignore.case = TRUE) :
     PCRE pattern compilation error
    'unrecognized character follows \'
    at 'images'
   Error in grepl(e, files, perl = TRUE, ignore.case = TRUE) : 
     invalid regular expression '^\images'
   Execution halted
Error: Failed to install 'CDECRetrieve' from GitHub:
  System command 'R' failed, exit status: 1, stdout + stderr:
E> * checking for file ‘/private/var/folders/fj/spwz4xrj5x35c5jfh2vrxn240000gp/T/RtmpOqH16D/remotes22e1ccb39f8/FlowWest-CDECRetrieve-105e61d/DESCRIPTION’ ... OK
E> * preparing ‘CDECRetrieve’:
E> * checking DESCRIPTION meta-information ... OK
E> Warning in grepl(e, files, perl = TRUE, ignore.case = TRUE) :
E>   PCRE pattern compilation error
E>  'unrecognized character follows \'
E>  at 'images'
E> Error in grepl(e, files, perl = TRUE, ignore.case = TRUE) : 
E>   invalid regular expression '^\images'
E> Execution halted
tungttnguyen commented 4 years ago

I'm having the same problem on Windows OS & R 4.0.1

ergz commented 4 years ago

thanks for bringing it up, I am going to test this out on a 4.0 installation, my guess is the the way the R build ignore file is being parsed on install

ergz commented 4 years ago

build ignore has been updated and I successfully installed on ubuntu 20.04 R version 4.0.1, note also I changed the install process to use remotes::install_github instead of devtools::install_github the latter has been deprecated