search

FlowWest / CDECRetrieve

An R package to retrieve CDEC data
https://flowwest.github.io/CDECRetrieve/
Other
7 stars 5 forks source link

Improves rt functions, adds trycatch, and adds tests #58

Closed ErinCain closed 3 years ago

ErinCain commented 3 years ago

See issue #54 Closes #54

ergz commented 3 years ago

Need to close connection on error

You should be able to call closeAllConnections() within the function that catches the error, alternatively you can use on.exit(closeAllConnections()) to close all connection when the function finishes execution.

thesadie commented 3 years ago

@ErinCain Instead of merging to master, let's create a branch for the v1.0 and all these issues you are tackling can merge to there everything else looks good :+1:

ErinCain commented 3 years ago

@ErinCain Instead of merging to master, let's create a branch for the v1.0 and all these issues you are tackling can merge to there everything else looks good 👍

Sounds good! Will do