FlowWest / habistat

https://flowwest.github.io/habistat/
0 stars 0 forks source link

Spawning HSI fix #31

Closed skylerlewis closed 1 month ago

skylerlewis commented 1 month ago

Fix vector_dvhsi_spawning function definition

Currently it is set to DHSI * VHSI. This works if DHSI and VHSI are both binary, but for spawning VHSI is continuous [0, 1], resulting in significant over-estimate.

Update to sqrt(DHSI * VHSI) for a geometric mean -- this is the standard method of combining continuous HS indices, as in the Yuba report and others. An extra-conservative method would be min(DHSI, VHSI)

Likewise, for duration_apply_dhsi_to_fsa_curve, marigial addition of durwua should be sqrt(dhsi) * wua_added and marginal subtraction should be sqrt(cumgmean(dhsi)) * wua_removed

skylerlewis commented 1 month ago

fixed in PR #35