Make datapoint alias customizable

Flowframe / laravel-trend

Generate trends for your models. Easily generate charts or reports.

MIT License

670 stars 70 forks source link

Make datapoint alias customizable #13

Closed haheap closed 1 year ago

haheap commented 2 years ago

Previously the aggregate() function would use the keyword date as a temporary column name. This would interfere with tables that already contain a column name date. This PR make the temporary column name customizable, but keeps date as the default to avoid a potential breaking change. Fix #8

Larsklopstra commented 2 years ago

Looks good, could you run php-cs-fixer @haheap?

haheap commented 2 years ago

Oops, sorry. Done! :-) Hope I did it correctly - I believe it used the php-cs-fixer config in the repo.

margarizaldi commented 2 years ago

Hi, when this PR will be merged? I don't want to change my "date" column, which requires me (and probably many other people) to modify bunch of codes.

For now I choose to modify the vendor file (by copying this PR), but hopefully not doing this for a long time.

Larsklopstra commented 1 year ago

Fixed #28