search

FlowingCode / ChipFieldAddon

Vaadin Flow integration of https://github.com/ThomasCybulski/paper-chip
Apache License 2.0
7 stars 5 forks source link

Conventional commits #22

Closed ngonzalezpazFC closed 3 years ago

ngonzalezpazFC commented 3 years ago

Mention that commit ad9c6b6 closes #7

Done

javier-godoy commented 3 years ago

@mlopezFC @ngonzalezpazFC Can you take a look at this? I'll rebase it after it's approved.

javier-godoy commented 3 years ago

@mlopezFC

Just a thought: shouldn't this commit's type be "build(test)"?

test is not a scope.

ngonzalezpazFC commented 3 years ago

@mlopezFC @ngonzalezpazFC Can you take a look at this? I'll rebase it after it's approved.

LGTM

mlopezFC commented 3 years ago

@mlopezFC

Just a thought: shouldn't this commit's type be "build(test)"?

test is not a scope.

Yes, you're right, I might have gotten confused given that test is a scope in maven. LGTM