search

FlowingCode / ChipFieldAddon

Vaadin Flow integration of https://github.com/ThomasCybulski/paper-chip
Apache License 2.0
7 stars 5 forks source link

Fix code smells #23

Closed ngonzalezpazFC closed 3 years ago

ngonzalezpazFC commented 3 years ago

Add serialization test

ngonzalezpazFC commented 3 years ago

Please rebase (because this PR was based on the old master). It's not clear which of the commits belong to this PR.

Should this commit message be "feat: implement Serializable"?

javier-godoy commented 3 years ago

Should this commit (2903eea2) message be "feat: implement Serializable"? No, because the commit only adds the serialization test (the component was already serializable)