search

FlowingCode / ChipFieldAddon

Vaadin Flow integration of https://github.com/ThomasCybulski/paper-chip
Apache License 2.0
7 stars 5 forks source link

Chip can not be used as a standalone component, due to visibility #8

Closed lucascapicotto closed 4 years ago

lucascapicotto commented 4 years ago

We want to use the Chip component outside of the ChipField component, all it would it take is changing the visibility of Chip to public.

javier-godoy commented 4 years ago

I see it was intentionally made package-private at some point (https://github.com/FlowingCode/ChipFieldAddon/commit/7c9c909506121d5f0364b4bea15d83ba258def25#diff-c053ac6056a1c6514826b0e882562a8f) but it's a good idea to make it public.

javier-godoy commented 4 years ago

Thanks for the pull request. Changes were released in version 2.1.0