Closed javier-godoy closed 3 years ago
Totally, we need to clarify that. IMHO I think it's clear which of those options to choose, here are some examples (based on style changes):
Will provide clarification through examples. Feel free to reopen if you consider that we need to rewrite other parts of the document.
The
style
type addresses changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc). We need to clarify (through an example) that changes to the application "styles" (Cascading Style Sheets_) and visual content are notstyle
commits.https://github.com/conventional-commits/conventionalcommits.org/issues/240 seems to suggest
refactor
orchore
(when the visual change is by itself neither afeat
nor afix
). However, we are definingrefactor
as "a code change" (thus replacing a PNG would not be covered under this type).chore: Maintenance changes not covered by other types. refactor: A code change that neither fixes a bug nor adds a feature feat: A new feature (correlates with MINOR in semantic versioning) fix: A bug fix (correlates with PATCH in semantic versioning)