FlowingCode / ErrorWindowAddon

Error Window Vaadin Add-on
Apache License 2.0
9 stars 2 forks source link

Support for obtaining production/development mode from Vaadin in Vaadin 24 #79

Closed mlopezFC closed 4 months ago

mlopezFC commented 5 months ago

Feature proposal

Right now the implementation defines if the mode is production or not, based on a system property. In Vaadin 24 it is possible to obtain that configuration programatically. It would be great that by default that the production status to be obtained from there in Vaadin 24.

Describe solution expectations

My expectation is that the code should call [isProductionMode](https://vaadin.com/api/platform/current/com/vaadin/flow/server/AbstractConfiguration.html#isProductionMode())

Additional information

No response

javier-godoy commented 5 months ago

In version 2.0 of the add-on we had

https://github.com/FlowingCode/ErrorWindowAddon/blob/90137633f83098c9bbdd000d8264105ed13ffaac/error-window-vaadin/src/main/java/com/flowingcode/vaadin/addons/errorwindow/ErrorWindow.java#L185-L189