FlowingCode / GoogleMapsAddon

Vaadin Addon based on Google Maps Web Component
https://www.flowingcode.com/en/open-source/
Apache License 2.0
20 stars 7 forks source link

Markers: animationEnabled and optimized properties questions #43

Open paodb opened 3 years ago

paodb commented 3 years ago

This two properties have no effect on markers when set to true.

mlopezFC commented 2 years ago

Let's replace the first one for the animation property of the web component and try to see if it's working. Regarding the second one, let's just remove that.

paodb commented 2 years ago

The animation property doesn't seem to be working on the web-component so I need to investigate a little bit more before doing more changes.

paodb commented 1 year ago

As this encloses two diferent actions, I've created a new issue for the removal of the optimized option https://github.com/FlowingCode/GoogleMapsAddon/issues/81.

paodb commented 1 year ago

The animation part it's tricky, I followed several examples like https://developers.google.com/maps/documentation/javascript/examples/marker-animations#maps_marker_animations-html but the web-component it's not triggering the animation. And even if that works, the current property in the java side, "animationEnabled" is a boolean and the web-component property is "animation" and it expects a String representing one of the two possible animation values: DROP or BOUNCE. So I think this "animationEnabled" property should be deprecated if not removed.