search

FlowingCode / GoogleMapsAddon

Vaadin Addon based on Google Maps Web Component
https://www.flowingcode.com/en/open-source/
Apache License 2.0
20 stars 7 forks source link

Markers: support optimized option #81

Closed paodb closed 1 year ago

paodb commented 1 year ago

It was decided on https://github.com/FlowingCode/GoogleMapsAddon/issues/43#issuecomment-1074471908 to remove the option as it doesn't exists in the web component part and it does nothing when enabled.

javier-godoy commented 1 year ago

Even when this method does nothing, it's part of the public API. It should be deprecated with a comment mentioning that the method serves no purpose.

paodb commented 1 year ago

Maybe we need to re-think this. The idea of removing (now deprecating) the optimized option was because the web component side doesn't have that property, there for, does nothing if the property is set on the server side addon; but it could be added to the web component, as explained here. Would that be a better approach?

paodb commented 1 year ago

As discussed in 2023-01-16 daily, the optimized property should be added to the web-component part. Then server side addon should be updated to use that new property.

paodb commented 1 year ago

Back to To Do as no update was done yet on related web-component ticket.